I agree with all you said about "salt". "Salt" is the common name for table salt or sodium chloride. However, the question was "what do all salts have in common". Sodium chloride is NOT the only "salt". Salts are a classification of compounds formed from the neutralization of an acid and a base. The questioner was looking for commonality in this class of compounds. No need to get upset!